Re: [PATCH] builtin/add: add a missing newline to an stderr message
- From
René Scharfe <l.s.r@web.de>
- Date
- Aug 8, 2017, 21:45 UTC
- Message-ID
- <2821200b-0428-a5dd-9680-f291cee0ec47@web.de>
- In-Reply-To
- <4b0d092f-5a1b-73c7-38fe-48455099bcff@ramsayjones.plus.com>
Am 08.08.2017 um 23:36 schrieb Ramsay Jones:
Show 32 quoted lines
> > Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com> > --- > > Hi Junio, > > I noticed this while looking into the t3700 failure on cygwin tonight. > Also, I couldn't decide whether or not to add the i18n '_()' brackets > around the message. In the end I didn't, but will happily add them > if you think I should. > > Thanks! > > ATB, > Ramsay Jones > > builtin/add.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/builtin/add.c b/builtin/add.c > index e888fb8c5..385b53ae7 100644 > --- a/builtin/add.c > +++ b/builtin/add.c > @@ -43,7 +43,7 @@ static void chmod_pathspec(struct pathspec *pathspec, int force_mode) > continue; > > if (chmod_cache_entry(ce, force_mode) < 0) > - fprintf(stderr, "cannot chmod '%s'", ce->name); > + fprintf(stderr, "cannot chmod '%s'\n", ce->name); > } > } >
FYI: I brought this up yesterday in the original thread, along with a few other observations:
https://public-inbox.org/git/3c61d9f6-e0fd-22a4-68e0-89fd9ce9b944@web.de/
Not sure if the discussion can or should be revived after all this time, though; just sending patches like yours might be the way to go.
René