git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bash: offer to show (un)staged changes

From
TATuncer Ayaz <tuncer.ayaz@gmail.com>
Date
Feb 1, 2009, 22:48 UTC
Message-ID
<4ac8254d0902011448t242e7fcek3ae7fda609648ef0@mail.gmail.com>
In-Reply-To
<20090119172939.GA14053@spearce.org>
On Mon, Jan 19, 2009 at 6:29 PM, Shawn O. Pearce <spearce@spearce.org> wrote:
Show 15 quoted lines
> Junio C Hamano <gitster@pobox.com> wrote:
>> Thomas Rast <trast@student.ethz.ch> writes:
>>
>> > +           if test ! -z "$GIT_PS1_EXPENSIVE"; then
>> > +                   git update-index --refresh >/dev/null 2>&1 || w="*"
>>
>> This makes the feature unavailable for people who care about the stat
>> dirtiness and explicitly set diff.autorefreshindex to false, doesn't it?
>
> Yup, and I'm one of those people who sets autorefresindex to false
> in my ~/.gitconfig, usually before I even have user.{name,email} set.
>
> I do like the idea of what Thomas is trying to do here, but its
> so bloody expensive to compute dirty state on every prompt in
> some repositories that I'd shoot myself.  E.g. WebKit is huge,

I've been thinking about this and wondered whether implementing "status --mini" or "status --short" which prints "+?*" in wt-status.c could be made fast enough.

Should we try to implement and profile this or do we know it will be slow beforehand?

I am actually using this feature on the bash prompt via calls to git commands and parsing for added=+, unknown=? and changed=* as others have done in combination with __git_ps1.

Show 18 quoted lines
> computing the dirty state inside of the WebKit repository on each
> prompt would absolutely kill CLI performance to a point of it not
> being usuable.  But git.git is small enough its OK on pretty much
> everything except Cygwin.
>
> So as much as I'd like to use this without the update-index --refresh
> bit, I'm not sure its viable in every project out there.  If we had
> an inotify sort of daemon to keep the data current so the prompt
> doesn't have to stat every source file on every display it would
> be reasonable, but we don't have such a thing yet for Git.
>
> --
> Shawn.
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
Previous: Shawn O. PearceNext: Junio C Hamano
Message 17 of 22 in “bash: offer to show (un)staged changes”
  1. bash: offer to show (un)staged changesThomas Rast, Jan 18, 2009
  2. Junio C HamanoJan 18, 2009
  3. Thomas RastJan 18, 2009
  4. Shawn O. PearceJan 19, 2009
  5. Martin LanghoffJan 19, 2009
  6. Shawn O. PearceJan 19, 2009
  7. Mike HommeyJan 19, 2009
  8. Martin LanghoffJan 19, 2009
  9. Boyd Stephen Smith Jr.Jan 19, 2009
  10. Martin LanghoffJan 19, 2009
  11. Boyd Stephen Smith Jr.Jan 19, 2009
  12. bash: offer to show (un)staged changesThomas Rast, Jan 19, 2009
  13. bash: offer to show (un)staged changesThomas Rast, Feb 1, 2009
  14. Shawn O. PearceFeb 1, 2009
  15. bash: offer to show (un)staged changesThomas Rast, Feb 3, 2009
  16. Shawn O. PearceFeb 3, 2009
  17. Tuncer AyazFeb 1, 2009
  18. Junio C HamanoFeb 1, 2009
  19. Tuncer AyazFeb 2, 2009
  20. Tuncer AyazFeb 2, 2009
  21. Junio C HamanoJan 18, 2009
  22. Thomas RastJan 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.