Re: [PATCH/RFC v2 2/4] remote-curl: send the refs to fetch-pack on stdin
- From
Ivan Todoroski <grnch@gmx.net>
- Date
- Mar 27, 2012, 23:20 UTC
- Message-ID
- <4F724B3C.2070702@gmx.net>
- In-Reply-To
- <7v8vimj73n.fsf@alter.siamese.dyndns.org>
On 27.03.2012 19:18, Junio C Hamano wrote:
Show 8 quoted lines
> Ivan Todoroski <grnch@gmx.net> writes: > >> + strbuf_init(&preamble, 4); > > Curious. > > If "4" does not really matter, I would drop this and use STRBUF_INIT at > the beginning instead.
I only put 4 because I know the strbuf will always have at least 4 bytes, because it always includes a flush packet. It doesn't matter at all otherwise, I will do as you suggest.