Re: [PATCH/RFC 2/2] remote-curl: send the refs to fetch-pack on stdin
- From
Jeff King <peff@peff.net>
- Date
- Mar 25, 2012, 01:24 UTC
- Message-ID
- <20120325012432.GD27651@sigill.intra.peff.net>
- In-Reply-To
- <4F6E3478.3090505@gmx.net>
On Sat, Mar 24, 2012 at 09:54:16PM +0100, Ivan Todoroski wrote:
Show 6 quoted lines
> From 723a561946824ee367f57f0d9b9d336a6bc28d13 Mon Sep 17 00:00:00 2001 > From: Ivan Todoroski <grnch@gmx.net> > Date: Sat, 24 Mar 2012 15:53:36 +0100 > Subject: [PATCH/RFC 2/2] remote-curl: send the refs to fetch-pack on stdin > > ---
Same comments as patch 1. Drop this stuff, and add in more commit message. :)
> remote-curl.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-)
Overall the code looks sane to me. One minor comment:
> -static int rpc_service(struct rpc_state *rpc, struct discovery *heads) > +static int rpc_service(struct rpc_state *rpc, struct discovery *heads, > + int nr_fetch, struct ref **to_fetch)
I was curious why you needed to add new arguments for this, since we surely must be passing the information into rpc_service already (since it has to put them on the command line). And the answer is that they are already in the argv member of the struct rpc_state. I wonder if it would fit the existing style of the code to pass the arguments through a member in the rpc_state in the same way. I don't feel strongly about it, though.
-Peff