Re: [PATCH] Use SHELL_PATH to fork commands in run_command.c:prepare_shell_cmd

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Mar 27, 2012, 06:23 UTC
Message-ID: <4F715CDA.2010500@viscovery.net>
In-Reply-To: <20120327032917.GB17338@sigill.intra.peff.net>

Am 3/27/2012 5:29, schrieb Jeff King:

Show 15 quoted lines

> On Mon, Mar 26, 2012 at 10:41:18PM -0400, Ben Walton wrote:
>> diff --git a/run-command.c b/run-command.c
>> index 1db8abf..f005a31 100644
>> --- a/run-command.c
>> +++ b/run-command.c
>> @@ -4,6 +4,10 @@
>>  #include "sigchain.h"
>>  #include "argv-array.h"
>>  
>> +#ifndef SHELL_PATH
>> +# define SHELL_PATH "sh"
>> +#endif
> 
> Does this default ever kick in? The Makefile defaults SHELL_PATH to
> /bin/sh, so we will always end up with at least that.

People do use this code outside git. Providing a fallback here would help them.

-- Hannes