Re: [PATCH] Use SHELL_PATH from build system in run_command.c:prepare_shell_cmd

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 29, 2012, 06:09 UTC
Message-ID: <20120329060936.GB2026@burratino>
In-Reply-To: <7v8vikrr5l.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

> Ben Walton <bwalton@artsci.utoronto.ca> writes:

Show 10 quoted lines

>> Possible fixes for this issue are:
>> ...
>> 2. The git wrapper could prepend SANE_TOOL_PATH to PATH for
>>    consistency with builtin commands.
>>
>> 3. The run_command.c:prepare_shell_command() could use the same
>>    SHELL_PATH that is in the #! line of all all scripts.
>> ...
>> Option 2 is voided by the same example that turned up this issue.
>> SANE_TOOL_PATH might also include 'insane' tools.

[...]

> This line of reasoning makes me feel uneasy.

I think the missing detail in the above explanation is that "sh" is a special case. Even though POSIX and good sense would require "sh" to name a reasonable shell just like "grep" needs to name a reasonable grep, on Solaris we have never been able to count on an "sh" for git's needs and common practice seems to be to give up and just use bash or ksh.

See v1.5.5-rc0~5^2~3 (filter-branch: use $SHELL_PATH instead of 'sh', 2008-03-12), for example.