git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tests: modernise style: more uses of test_line_count

From
Stefano Lattarini <stefano.lattarini@gmail.com>
Date
Mar 9, 2012, 23:00 UTC
Message-ID
<4F5A8B77.7020900@gmail.com>
In-Reply-To
<7vpqcl4diw.fsf@alter.siamese.dyndns.org>
On 03/09/2012 11:26 PM, Junio C Hamano wrote:
Show 10 quoted lines
> Stefano Lattarini <stefano.lattarini@gmail.com> writes:
> 
>>  This change modernizes one (and just one) kind of obsolescent idiom
>>  throughout (almost) all the tests, rather than tweaking one single test
>>  with lots of different and unrelated modernizations.  This approach
>>  seems safer, and IMHO makes for patches easier to write and review.
> 
> Yes, but during the pre-release "regression fix only" period is not
> a good time to do so.
>

Sorry, I don't follow the list well enough to know when a release is imminent. But you of course right that the maintainers shouldn't be distracted with cosmetic/tweaking patches when a release is in preparation. I will ping this patch once 1.7.10 is out then (and put similar patches on hold until then).

Thanks, and sorry for the noise,
  Stefano
Previous: Junio C Hamano
Message 3 of 3 in “tests: modernise style: more uses of test_line_count”
  1. tests: modernise style: more uses of test_line_countStefano Lattarini, Mar 9, 2012
  2. Junio C HamanoMar 9, 2012
  3. Stefano LattariniMar 9, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.