From: Stefano Lattarini Date: Fri, 09 Mar 2012 23:00:07 GMT Subject: Re: [PATCH] tests: modernise style: more uses of test_line_count Message-ID: <4F5A8B77.7020900@gmail.com> In-Reply-To: <7vpqcl4diw.fsf@alter.siamese.dyndns.org> On 03/09/2012 11:26 PM, Junio C Hamano wrote: > Stefano Lattarini writes: > >> This change modernizes one (and just one) kind of obsolescent idiom >> throughout (almost) all the tests, rather than tweaking one single test >> with lots of different and unrelated modernizations. This approach >> seems safer, and IMHO makes for patches easier to write and review. > > Yes, but during the pre-release "regression fix only" period is not > a good time to do so. > Sorry, I don't follow the list well enough to know when a release is imminent. But you of course right that the maintainers shouldn't be distracted with cosmetic/tweaking patches when a release is in preparation. I will ping this patch once 1.7.10 is out then (and put similar patches on hold until then). Thanks, and sorry for the noise, Stefano