git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] archive: fix archive generation for empty trees

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
Mar 8, 2012, 17:46 UTC
Message-ID
<4F58F05A.1010606@lsrfire.ath.cx>
In-Reply-To
<20120308071559.GF7643@sigill.intra.peff.net>
Am 08.03.2012 08:15, schrieb Jeff King:
Show 12 quoted lines
> On Wed, Mar 07, 2012 at 10:38:07PM -0800, Junio C Hamano wrote:
>
>>> ... However, prefix_pathspec does a lot of magic parsing;
>>> it's unclear to me whether this is all in support of properly
>>> adding the prefix, or if its side effects are important.
>>
>> These "magic" are for things like :(root)/path that will explicitly
>> refuse the prefix when run from a subdirectory.
>
> Yeah, that was my impression. In that case, I would think we could get
> rid of the get_pathspec call entirely, as it is purely about fixing-up
> prefixes, and we know that we have none.

Yes, I think you're right. Not sure why I didn't do that in ebfbdb34, when that empty prefix was introduced instead.

René
Previous: Jeff KingNext: Brodie Rao
Message 5 of 9 in “archive: fix archive generation for empty trees”
  1. archive: fix archive generation for empty treesBrodie Rao, Mar 8, 2012
  2. Jeff KingMar 8, 2012
  3. Junio C HamanoMar 8, 2012
  4. Jeff KingMar 8, 2012
  5. René ScharfeMar 8, 2012
  6. Brodie RaoMar 9, 2012
  7. René ScharfeMar 9, 2012
  8. René ScharfeMar 8, 2012
  9. Brodie RaoMar 9, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.