git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Add a setting to require a filter to be successful

From
JBJehan Bing <jehan@orb.com>
Date
Feb 18, 2012, 00:43 UTC
Message-ID
<4F3EF43D.2040102@orb.com>
In-Reply-To
<7vd39dqa1i.fsf@alter.siamese.dyndns.org>
On 2012-02-17 16:07, Junio C Hamano wrote:
Show 7 quoted lines
> A few test in t0021 use 'false' as the filter, which can exit without
> reading any byte from us, before we start writing and causes us to die
> with SIGPIPE, leading to intermittent test failure.  I think treating this
> as a failure of running the filter (the end user's filter should read what
> is fed in full, produce its output and write the result back to us) is the
> right thing to do, and this patch needs more work to handle such a
> situation better, probably by using sigchain_push(SIGPIPE) or something.

If I understand what you're saying, current version of git already have the problem: if a filter fails without reading anything, git will die instead of using the unfiltered content. My patch has only made the issue apparent by testing with a failing filter. Am I understanding correctly?

Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 8 in “Add an option to require a filter to be successful”
  1. Add an option to require a filter to be successfulJehan Bing, Feb 16, 2012
  2. Junio C HamanoFeb 17, 2012
  3. Add a setting to require a filter to be successfuljehan@orb.com, Feb 17, 2012
  4. Johannes SixtFeb 17, 2012
  5. Junio C HamanoFeb 17, 2012
  6. Junio C HamanoFeb 18, 2012
  7. Jehan BingFeb 18, 2012
  8. Junio C HamanoFeb 18, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.