Re: [PATCH v2] Add a setting to require a filter to be successful

From

Johannes Sixt <j.sixt@viscovery.net>

Date

Feb 17, 2012, 07:08 UTC

Message-ID

<4F3DFCD0.6070002@viscovery.net>

In-Reply-To

<4f3daaf7.e302440a.02ba.fffff463@mx.google.com>

Am 2/17/2012 2:19, schrieb jehan@orb.com:

> @@ -747,13 +753,19 @@ int convert_to_git(const char *path, const char *src, size_t len,

...

>  	ret |= apply_filter(path, src, len, dst, filter);
> +	if (!ret && required)
> +		die("required filter '%s' failed", ca.drv->name);

Wouldn't it be much more helpful if this were:

	die("%s: clean filter '%s' failed", path, ca.drv->name);

Likewise (with s/clean/smudge/) in convert_to_working_tree_internal().

> +	! git checkout -- test.fs

	test_must_fail git checkout -- test.fs

> +	! git add test.fc

	test_must_fail git add test.fc

-- Hannes