git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: rebase -i reword converts to pick on pre-commit non-zero exit

From
NKNeal Kreitzinger <nkreitzinger@gmail.com>
Date
Feb 1, 2012, 21:28 UTC
Message-ID
<4F29AE8E.6070109@gmail.com>
In-Reply-To
<jgcaoh$d9q$1@dough.gmane.org>
On 2/1/2012 3:27 PM, Neal Kreitzinger wrote:
Show 11 quoted lines
> When interactive rebase does the reword command it runs the pre-commit hook
> for that commit (a).  If the pre-commit hook gives a non-zero exit then
> interactive rebase picks commit (a) and continues to the next commit (b) in
> the rebase-to-do-list.  Instead of picking commit (a) when the pre-commit
> hook exits non-zero on the reword command, shouldn't interactive rebase
> learn to edit commit (a) and tell the user that because the pre-commit hook
> exited non-zero they need to either remedy the pre-commit hook violations
> and run git commit --amend or run git commit --amend --no-verify to bypass
> the pre-commit hook?  Otherwise, you have to run another rebase after the
> rejected rewords and edit those commits to accomplish the rewords.
>
git 1.7.1

v/r, neal

Previous: Neal KreitzingerNext: Andrew Wong
Message 2 of 4 in “rebase -i reword converts to pick on pre-commit non-zero exit”
  1. Neal KreitzingerFeb 1, 2012
  2. Neal KreitzingerFeb 1, 2012
  3. Andrew WongFeb 2, 2012
  4. Neal KreitzingerFeb 2, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.