From: Neal Kreitzinger Date: Wed, 01 Feb 2012 21:28:46 GMT Subject: Re: rebase -i reword converts to pick on pre-commit non-zero exit Message-ID: <4F29AE8E.6070109@gmail.com> In-Reply-To: On 2/1/2012 3:27 PM, Neal Kreitzinger wrote: > When interactive rebase does the reword command it runs the pre-commit hook > for that commit (a). If the pre-commit hook gives a non-zero exit then > interactive rebase picks commit (a) and continues to the next commit (b) in > the rebase-to-do-list. Instead of picking commit (a) when the pre-commit > hook exits non-zero on the reword command, shouldn't interactive rebase > learn to edit commit (a) and tell the user that because the pre-commit hook > exited non-zero they need to either remedy the pre-commit hook violations > and run git commit --amend or run git commit --amend --no-verify to bypass > the pre-commit hook? Otherwise, you have to run another rebase after the > rejected rewords and edit those commits to accomplish the rewords. > git 1.7.1 v/r, neal