git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test: errors preparing for a test are not special

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Dec 14, 2011, 08:51 UTC
Message-ID
<4EE863AF.2070606@viscovery.net>
In-Reply-To
<20111214082203.GB13166@elie.hsd1.il.comcast.net>
Am 12/14/2011 9:22, schrieb Jonathan Nieder:
Show 13 quoted lines
> Johannes Sixt wrote:
>> Am 12/13/2011 23:35, schrieb Joe Ratterman:
> 
>>>  test_expect_success TTY 'no pager with --no-pager' '
>>>  	rm -f paginated.out ||
>>>  	cleanup_fail &&
>>
>> What kind of bogosity do I see in the context of this hunk
> [...]
>> Wouldn't rm -f always succeed under normal circumstances, and then the
>> rest of the test would be skipped?
> 
> No, && and || are left-associative.

<Facepalm/> You are right, of course, and I should have known better. (I need more caffein.)

At any rate, your patch makes the code much more comprehensible.
-- Hannes
Previous: Jonathan NiederNext: Jonathan Nieder
Message 5 of 7 in “Gitweb: Avoid warnings when a repo does not have a valid HEAD”
  1. Gitweb: Avoid warnings when a repo does not have a valid HEADJoe Ratterman, Dec 13, 2011
  2. Add '-P' as a synonym for '--no-pager' in the git commandJoe Ratterman, Dec 13, 2011
  3. Johannes SixtDec 14, 2011
  4. test: errors preparing for a test are not specialJonathan Nieder, Dec 14, 2011
  5. Johannes SixtDec 14, 2011
  6. Jonathan NiederDec 14, 2011
  7. Jonathan NiederDec 14, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.