git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add '-P' as a synonym for '--no-pager' in the git command

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Dec 14, 2011, 07:44 UTC
Message-ID
<4EE853C0.20505@viscovery.net>
In-Reply-To
<1323815706-10560-2-git-send-email-jratt0@gmail.com>
Am 12/13/2011 23:35, schrieb Joe Ratterman:
Show 11 quoted lines
> +test_expect_success TTY 'no pager with -P' '
> +	rm -f paginated.out ||
> +	cleanup_fail &&
> +
> +	test_terminal git -P log &&
> +	! test -e paginated.out
> +'
> +
>  test_expect_success TTY 'no pager with --no-pager' '
>  	rm -f paginated.out ||
>  	cleanup_fail &&

What kind of bogosity do I see in the context of this hunk (and in the new text as well, but it is not entirely your fault, Joe, since you obviously have only copied an existing test snippet)?

Wouldn't rm -f always succeed under normal circumstances, and then the rest of the test would be skipped? This use of || was introduced by fdf1bc48 (t7006: guard cleanup with test_expect_success).

-- Hannes
Previous: Joe RattermanNext: Jonathan Nieder
Message 3 of 7 in “Gitweb: Avoid warnings when a repo does not have a valid HEAD”
  1. Gitweb: Avoid warnings when a repo does not have a valid HEADJoe Ratterman, Dec 13, 2011
  2. Add '-P' as a synonym for '--no-pager' in the git commandJoe Ratterman, Dec 13, 2011
  3. Johannes SixtDec 14, 2011
  4. test: errors preparing for a test are not specialJonathan Nieder, Dec 14, 2011
  5. Johannes SixtDec 14, 2011
  6. Jonathan NiederDec 14, 2011
  7. Jonathan NiederDec 14, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.