git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] compat/getpass.c: Fix a sparse "symbol not declared" warning

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Nov 30, 2011, 20:54 UTC
Message-ID
<4ED69803.6070508@ramsay1.demon.co.uk>
In particular, sparse complains as follows:
        SP compat/getpass.c
    compat/getpass.c:5:6: warning: symbol 'getpass_echo' was not \
        declared. Should it be static?

In order to suppress the warning, we include the getpass.h header file which contains an appropriate extern declaration.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Jeff,

When you next re-roll your most recent credentials/getpass series, could you please squash this patch in. (This patch was against pu @ 1cc922af, but I guess you need to apply a similar patch to commit 8eca119c "stub out getpass_echo function", 27-11-2011 instead)

Thanks!

ATB, Ramsay Jones

 compat/getpass.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/compat/getpass.c b/compat/getpass.c
index b5bd1dd..a145d27 100644
--- a/compat/getpass.c
+++ b/compat/getpass.c
@@ -1,4 +1,5 @@
 #include "../git-compat-util.h"
+#include "getpass.h"
 
 #ifdef HAVE_DEV_TTY
 
-- 
1.7.7
Next: Jeff King
Message 1 of 2 in “compat/getpass.c: Fix a sparse "symbol not declared" warning”
  1. compat/getpass.c: Fix a sparse "symbol not declared" warningRamsay Jones, Nov 30, 2011
  2. Jeff KingDec 1, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.