From: Ramsay Jones Date: Wed, 30 Nov 2011 20:54:27 GMT Subject: [PATCH] compat/getpass.c: Fix a sparse "symbol not declared" warning Message-ID: <4ED69803.6070508@ramsay1.demon.co.uk> In particular, sparse complains as follows: SP compat/getpass.c compat/getpass.c:5:6: warning: symbol 'getpass_echo' was not \ declared. Should it be static? In order to suppress the warning, we include the getpass.h header file which contains an appropriate extern declaration. Signed-off-by: Ramsay Jones --- Hi Jeff, When you next re-roll your most recent credentials/getpass series, could you please squash this patch in. (This patch was against pu @ 1cc922af, but I guess you need to apply a similar patch to commit 8eca119c "stub out getpass_echo function", 27-11-2011 instead) Thanks! ATB, Ramsay Jones compat/getpass.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/compat/getpass.c b/compat/getpass.c index b5bd1dd..a145d27 100644 --- a/compat/getpass.c +++ b/compat/getpass.c @@ -1,4 +1,5 @@ #include "../git-compat-util.h" +#include "getpass.h" #ifdef HAVE_DEV_TTY -- 1.7.7