git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] submodule::module_clone(): silence die() message from module_name()

From
Jens Lehmann <jens.lehmann@web.de>
Date
Oct 11, 2011, 17:38 UTC
Message-ID
<4E947F01.8040600@web.de>
In-Reply-To
<CALUzUxo6YEEpL_MhT=O9sJSUdwcpKBpeM2O8GkbbyxvqmWCFLQ@mail.gmail.com>
Am 11.10.2011 10:44, schrieb Tay Ray Chuan:
Show 13 quoted lines
> On Tue, Oct 11, 2011 at 3:34 AM, Jens Lehmann <Jens.Lehmann@web.de> wrote:
>> When cmd_foreach() passes an empty "name" variable to the
>> spawned command that might still work (and even make sense), but using the
>> empty name in cmd_sync() to access the config is looking like an error to
>> me. It might make sense to add an "|| exit" at least to the callsite in
>> cmd_sync(). Or am I missing something here?
> 
> Cc-ed David, who authored cmd_sync().
> 
> David, what do you think of Jens' analysis?
> 
> In the meantime, I'll probably reword the second paragraph to say that
> future work will be needed to analyze non- || exit callsites.

Yeah, me too thinks the missing "|| exit" should be subject of another patch.

Previous: Tay Ray ChuanNext: Tay Ray Chuan
Message 5 of 9 in “submodule: whitespace fix”
  1. 1/2 submodule: whitespace fixTay Ray Chuan, Oct 7, 2011
  2. 2/2 submodule::module_clone(): silence die() message from module_name()Tay Ray Chuan, Oct 7, 2011
  3. Jens LehmannOct 10, 2011
  4. Tay Ray ChuanOct 11, 2011
  5. Jens LehmannOct 11, 2011
  6. 0/2 submodule patchesTay Ray Chuan, Oct 21, 2011
  7. 1/2 submodule: whitespace fixTay Ray Chuan, Oct 21, 2011
  8. 2/2 submodule::module_clone(): silence die() message from module_name()Tay Ray Chuan, Oct 21, 2011
  9. Jens LehmannOct 10, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.