git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] submodule::module_clone(): silence die() message from module_name()

From
Tay Ray Chuan <rctay89@gmail.com>
Date
Oct 7, 2011, 09:04 UTC
Message-ID
<1317978295-4796-2-git-send-email-rctay89@gmail.com>
In-Reply-To
<1317978295-4796-1-git-send-email-rctay89@gmail.com>

The die() message that may occur in module_name() is not really relevant to the user when called from module_clone(); the latter handles the "failure" (no submodule mapping) anyway.

Leave other callers of module_name() unchanged, as the die() message shown is either relevant for user consumption (such as those that exit() when the call fails), or will not occur at all (when called with paths returned by module_list()).

Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
---
 git-submodule.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index ebea35b..3adab93 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -130,7 +130,7 @@ module_clone()
 
 	gitdir=
 	gitdir_base=
-	name=$(module_name "$path")
+	name=$(module_name "$path" 2>/dev/null)
 	base_path=$(dirname "$path")
 
 	gitdir=$(git rev-parse --git-dir)
-- 
1.7.7.584.g16d0ea
Previous: Tay Ray ChuanNext: Jens Lehmann
Message 2 of 9 in “submodule: whitespace fix”
  1. 1/2 submodule: whitespace fixTay Ray Chuan, Oct 7, 2011
  2. 2/2 submodule::module_clone(): silence die() message from module_name()Tay Ray Chuan, Oct 7, 2011
  3. Jens LehmannOct 10, 2011
  4. Tay Ray ChuanOct 11, 2011
  5. Jens LehmannOct 11, 2011
  6. 0/2 submodule patchesTay Ray Chuan, Oct 21, 2011
  7. 1/2 submodule: whitespace fixTay Ray Chuan, Oct 21, 2011
  8. 2/2 submodule::module_clone(): silence die() message from module_name()Tay Ray Chuan, Oct 21, 2011
  9. Jens LehmannOct 10, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.