Re: [PATCH] rebase -i: fix has_action

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Aug 5, 2011, 12:46 UTC
Message-ID: <4E3BE63E.8030509@viscovery.net>
In-Reply-To: <CAGdFq_j2wRw-gB109VypZkG1u=fm7yynkn2-Gu8AzNpVOrun8w@mail.gmail.com>

Am 8/5/2011 14:36, schrieb Sverre Rabbelier:

Show 12 quoted lines

> On Thu, Aug 4, 2011 at 21:34, Junio C Hamano <gitster@pobox.com> wrote:
>>        has_action () {
>>          test -s "$1"
>>        }
> 
>>        has_action () {
>>          sane_grep -v -e '^#' -e '^[   ]*$' "$1" >/dev/null
>>        }
> 
> I think the former more correctly checks what the function name
> implies, is there any downside to that which makes you suggest this
> second approach?

Yes. There might be editors where it is difficult to edit a non-empty file so that it becomes empty. I recall this was a problem for me with vi before I got intimately acquainted with it.

-- Hannes