Re: [RFC/PATCH] t0081-*.sh: Fix failure of the 'long read' tests
- From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
- Date
- Apr 30, 2011, 17:12 UTC
- Message-ID
- <4DBC4310.4000105@ramsay1.demon.co.uk>
- In-Reply-To
- <20110426193539.GA2616@elie>
Jonathan Nieder wrote:
Show 18 quoted lines
> Ramsay Jones wrote:
>
>> --- a/t/t0081-line-buffer.sh
>> +++ b/t/t0081-line-buffer.sh
>> @@ -25,8 +25,7 @@ generate_tens_of_lines () {
>> do
>> echo "$line"
>> done &&
>> - : $((i = $i + 1)) ||
>> - return
>> + i=$(($i + 1))
>> done
>
> This test is a mess. Could you try the patch from the tip of
>
> git://repo.or.cz/git/jrn.git svn-fe
>
> which just gets rid of it instead?Ah, so I didn't imagine the discussion to remove this test!
Yes, this works great for me. So, I will keep skipping the test until this patch makes it into git.git.
Thanks!
ATB, Ramsay Jones