Re: [PATCH/RFC 2/2] format-patch: show notes as message after the ---

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Apr 26, 2011, 09:44 UTC
Message-ID: <4DB693F5.4090803@drmicha.warpmail.net>
In-Reply-To: <201104261128.58527.johan@herland.net>

Johan Herland venit, vidit, dixit 26.04.2011 11:28:

Show 30 quoted lines

> On Tuesday 26 April 2011, Michael J Gruber wrote:
>> When requesting notes with "--notes", "format-patch" produces notes
>> within the commit message which "am" misunderstands as being part of
>> the message.
>>
>> Change this so that notes are displayed after an additional "---".
>> Any "am" (old or new) will ignore that, so that it is a safe place
>> for additional comments:
>>
>> Log message
>> "---"
>> notes
>> "---"
>> diffstat
>> patch
>>
>> (The first "---" appears only when there is a note, of course.)
>>
>> Later on (say with "--format-notes") the output format can be changed
>> easily to accomodate a future "am" which knows how to create notes
>> from such patches.
>>
>> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
> 
> Acked-by: Johan Herland <johan@herland.net>
> 
> (goes for 1/2 as well)
> 
> 
> /me likes :)

Thanks :)

BTW: Just before hitting "send-mail", I thought of quoting the "---" in
my commit message where I describe the format. I wonder what would have
happened else when am-ing that message...

Michael