git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC 2/2] format-patch: show notes as message after the ---

From
Johan Herland <johan@herland.net>
Date
Apr 26, 2011, 09:28 UTC
Message-ID
<201104261128.58527.johan@herland.net>
In-Reply-To
<826def15eb7204ee30fc4c358f72103ec75b4e42.1303808057.git.git@drmicha.warpmail.net>
On Tuesday 26 April 2011, Michael J Gruber wrote:
Show 22 quoted lines
> When requesting notes with "--notes", "format-patch" produces notes
> within the commit message which "am" misunderstands as being part of
> the message.
>
> Change this so that notes are displayed after an additional "---".
> Any "am" (old or new) will ignore that, so that it is a safe place
> for additional comments:
>
> Log message
> "---"
> notes
> "---"
> diffstat
> patch
>
> (The first "---" appears only when there is a note, of course.)
>
> Later on (say with "--format-notes") the output format can be changed
> easily to accomodate a future "am" which knows how to create notes
> from such patches.
>
> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
Acked-by: Johan Herland <johan@herland.net>
(goes for 1/2 as well)
/me likes :)
...Johan
-- 
Johan Herland, <johan@herland.net>
www.herland.net
Previous: Michael J GruberNext: Michael J Gruber
Message 3 of 6 in “notes/pretty: allow callers to set the notes format from struct rev_info”
  1. 1/2 notes/pretty: allow callers to set the notes format from struct rev_infoMichael J Gruber, Apr 26, 2011
  2. 2/2 format-patch: show notes as message after the ---Michael J Gruber, Apr 26, 2011
  3. Johan HerlandApr 26, 2011
  4. Michael J GruberApr 26, 2011
  5. Junio C HamanoApr 26, 2011
  6. Michael J GruberApr 27, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.