git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git pull: Remove option handling done by fetch

From
Jens Lehmann <jens.lehmann@web.de>
Date
Feb 4, 2011, 20:17 UTC
Message-ID
<4D4C5EBC.2090100@web.de>

In commits be254a0ea9 and 7dce19d374 the handling of the new fetch options "--[no-]recurse-submodules" had been added to git-pull.sh. This was not necessary because all options to "git fetch" are passed to it and handled there, so lets remove them.

Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
---
I noticed this while implementing the on-demand recursive fetch.
 git-pull.sh |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/git-pull.sh b/git-pull.sh
index eb87f49..20a3bbe 100755
--- a/git-pull.sh
+++ b/git-pull.sh
@@ -38,7 +38,7 @@ test -z "$(git ls-files -u)" || die_conflict
 test -f "$GIT_DIR/MERGE_HEAD" && die_merge

 strategy_args= diffstat= no_commit= squash= no_ff= ff_only=
-log_arg= verbosity= progress= recurse_submodules=
+log_arg= verbosity= progress=
 merge_args=
 curr_branch=$(git symbolic-ref -q HEAD)
 curr_branch_short="${curr_branch#refs/heads/}"
@@ -105,12 +105,6 @@ do
 	--no-r|--no-re|--no-reb|--no-reba|--no-rebas|--no-rebase)
 		rebase=false
 		;;
-	--recurse-submodules)
-		recurse_submodules=--recurse-submodules
-		;;
-	--no-recurse-submodules)
-		recurse_submodules=--no-recurse-submodules
-		;;
 	--d|--dr|--dry|--dry-|--dry-r|--dry-ru|--dry-run)
 		dry_run=--dry-run
 		;;
@@ -223,7 +217,7 @@ test true = "$rebase" && {
 	done
 }
 orig_head=$(git rev-parse -q --verify HEAD)
-git fetch $verbosity $progress $dry_run $recurse_submodules --update-head-ok "$@" || exit 1
+git fetch $verbosity $progress $dry_run --update-head-ok "$@" || exit 1
 test -z "$dry_run" || exit 0

 curr_head=$(git rev-parse -q --verify HEAD)
-- 
1.7.4.31.g5ae186
Next: Johannes Sixt
Message 1 of 11 in “git pull: Remove option handling done by fetch”
  1. git pull: Remove option handling done by fetchJens Lehmann, Feb 4, 2011
  2. Johannes SixtFeb 4, 2011
  3. Jens LehmannFeb 5, 2011
  4. Junio C HamanoFeb 6, 2011
  5. Jens LehmannFeb 6, 2011
  6. Jonathan NiederFeb 6, 2011
  7. Jens LehmannFeb 6, 2011
  8. Jonathan NiederFeb 7, 2011
  9. pull: Document the "--[no-]recurse-submodules" optionsJens Lehmann, Feb 7, 2011
  10. Junio C HamanoFeb 7, 2011
  11. pull: Document the "--[no-]recurse-submodules" optionsJens Lehmann, Feb 7, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.