git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git pull: Remove option handling done by fetch

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Feb 6, 2011, 22:09 UTC
Message-ID
<20110206220939.GC17210@elie>
In-Reply-To
<4D4F19D0.2000408@web.de>
Jens Lehmann wrote:
> Am 06.02.2011 21:45, schrieb Junio C Hamano:
>> Jens Lehmann <Jens.Lehmann@web.de> writes:
Show 6 quoted lines
>>> Yes, but isn't that exactly what the pull man-page says? Quote:
>>> "Options meant for git pull itself and the underlying git merge
>>> must be given before the options meant for git fetch."
>> 
>> Yes, it says that, and I think that was a weasely way to say "the command
>> line parser in git-pull is broken".
[...]
> (CCed Jonathan, as he is the author of the lines I quoted)

They're from Junio. :) See v1.5.4.5~26 (git-pull documentation: warn about the option order, 2008-03-10).

I also agree that (1) it would be very nice to find a way to fix this and (2) until then, it seems best as a general principle not to regress in those odd cases where we sort of fixed it.

In other words, if we were adding --recurse-submodules today, I'd agree that it should be treated like other fetch options, but we already added the option and some people/scripts might be used to the added flexibility, no?

Previous: Jens LehmannNext: Jens Lehmann
Message 6 of 11 in “git pull: Remove option handling done by fetch”
  1. git pull: Remove option handling done by fetchJens Lehmann, Feb 4, 2011
  2. Johannes SixtFeb 4, 2011
  3. Jens LehmannFeb 5, 2011
  4. Junio C HamanoFeb 6, 2011
  5. Jens LehmannFeb 6, 2011
  6. Jonathan NiederFeb 6, 2011
  7. Jens LehmannFeb 6, 2011
  8. Jonathan NiederFeb 7, 2011
  9. pull: Document the "--[no-]recurse-submodules" optionsJens Lehmann, Feb 7, 2011
  10. Junio C HamanoFeb 7, 2011
  11. pull: Document the "--[no-]recurse-submodules" optionsJens Lehmann, Feb 7, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.