[PATCH maint] start_command: flush buffers in the WIN32 code path as well
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- Feb 4, 2011, 08:41 UTC
- Message-ID
- <4D4BBBD6.7010100@viscovery.net>
- In-Reply-To
- <alpine.DEB.1.00.1102031426110.1541@bonsai2>
From: Johannes Sixt <j6t@kdbg.org>
The POSIX code path did The Right Thing already, but we have to do the same on Windows.
This bug caused failures in t5526-fetch-submodules, where the output of 'git fetch --recurse-submodules' was in the wrong order.
Debugged-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> Signed-off-by: Johannes Sixt <j6t@kdbg.org> --- Am 2/3/2011 21:26, schrieb Johannes Schindelin:
> Have you seen my response where I proved that it is a fflush() issue, most > likely with mingw_spawn()?
I think this is the correct fix.
run-command.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/run-command.c b/run-command.c index 2a1041e..f91e446 100644 --- a/run-command.c +++ b/run-command.c @@ -194,6 +194,7 @@ fail_pipe: } trace_argv_printf(cmd->argv, "trace: run_command:"); + fflush(NULL); #ifndef WIN32 { @@ -201,7 +202,6 @@ fail_pipe: if (pipe(notify_pipe)) notify_pipe[0] = notify_pipe[1] = -1; - fflush(NULL); cmd->pid = fork(); if (!cmd->pid) { /*
-- 1.7.4.1253.g00c7