Re: [msysGit] [PATCH 4/4] t5526: avoid dependency on submodule order
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Feb 3, 2011, 20:08 UTC
- Message-ID
- <201102032108.54811.j6t@kdbg.org>
- In-Reply-To
- <1296747105-1663-5-git-send-email-patthoyts@users.sourceforge.net>
On Donnerstag, 3. Februar 2011, Pat Thoyts wrote:
> +test_cmp_unordered() {
> + grep --line-regexp -f "$@" >&3
> +}I don't think that this is sufficiently portable.
Furthermore, just like Dscho, I'd rather prefer to know why the output is not ordered as expected.
I'm fine with the other patches as well.
A side note regarding SYMLINKS: It's actually possible to remove 70 of the 130 SYMLINKS checks from the test suite:
http://repo.or.cz/w/git/mingw/j6t.git/shortlog/refs/heads/war-on-symlinks
-- Hannes