Re: [PATCH v2] Disallow empty section and variable names
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- Jan 31, 2011, 07:48 UTC
- Message-ID
- <4D46694F.5070208@viscovery.net>
- In-Reply-To
- <20110130203445.GA9689@fm.suse.cz>
Am 1/30/2011 21:34, schrieb Libor Pechacek:
Show 8 quoted lines
> It is possible to break your repository config by creating an invalid key. The > config parser in turn chokes on it. > > $ git init > Initialized empty Git repository in /tmp/gittest/.git/ > $ git config .foo false > $ git config .foo > fatal: bad config file line 6 in .git/config
Just a nit: Your example is misleading because it "only" shows that if you shove in junk, and ask for junk, you get breakage. However, the breakage is much more serious, and you could have demonstrated it, if you had written your example like this:
$ git config .foo false $ git config user.email fatal: bad config file line 6 in .git/config
> + test_must_fail git config . && > + test_must_fail git config .foo && > + test_must_fail git config foo. && > + test_must_fail git config .foo. &&
Not a nit: These tests only show that 'git config' cannot be asked for junk, but they do not show that you cannot insert junk into the config file anymore using 'git config'.
-- Hannes