Re: [PATCH v2] Disallow empty section and variable names
- From
- Libor Pechacek <lpechacek@suse.cz>
- Date
- Jan 31, 2011, 09:17 UTC
- Message-ID
- <20110131091728.GB24297@fm.suse.cz>
- In-Reply-To
- <4D46694F.5070208@viscovery.net>
On Mon 31-01-11 08:48:31, Johannes Sixt wrote:
Show 18 quoted lines
> Am 1/30/2011 21:34, schrieb Libor Pechacek: > > It is possible to break your repository config by creating an invalid key. The > > config parser in turn chokes on it. > > > > $ git init > > Initialized empty Git repository in /tmp/gittest/.git/ > > $ git config .foo false > > $ git config .foo > > fatal: bad config file line 6 in .git/config > > Just a nit: Your example is misleading because it "only" shows that if you > shove in junk, and ask for junk, you get breakage. However, the breakage > is much more serious, and you could have demonstrated it, if you had > written your example like this: > > $ git config .foo false > $ git config user.email > fatal: bad config file line 6 in .git/config
Yes, that one is more persuasive. Thanks for hint.
Show 8 quoted lines
> > + test_must_fail git config . && > > + test_must_fail git config .foo && > > + test_must_fail git config foo. && > > + test_must_fail git config .foo. && > > Not a nit: These tests only show that 'git config' cannot be asked for > junk, but they do not show that you cannot insert junk into the config > file anymore using 'git config'.
This change builds on top of "Sanity-check config variable names" which makes setting and getting values use the same key checking routine. For the moment, it does not matter if we test the "set" ot "get" path.
Yet, I accept the get/set operations can use different key checking routine in the future (although I can't imagine the reson for it), and overall testing the "set" path is in line with the idea of the patch.
Thanks for input, I'll send updated patch.
Libor
-- Libor Pechacek SUSE L3 Team, Prague