Re: [RFC/PATCH] t9157-*.sh: Add an svn version check
- From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
- Date
- Jan 11, 2011, 18:21 UTC
- Message-ID
- <4D2C9FBA.9080306@ramsay1.demon.co.uk>
- In-Reply-To
- <1294478342.2791.4.camel@fixed-disk>
Anders Kaseorg wrote:
Show 9 quoted lines
> On Thu, 2011-01-06 at 18:29 +0000, Ramsay Jones wrote: >> +svn_ver="$(svn --version --quiet)" >> +case $svn_ver in >> +[0-1].[0-4].[0-6]) > > Thanks for the patch. Can I suggest the more precise > > 0.* | 1.[0-4].*) >
Heh, yeah that would be more accurate! Thanks. ;-)
Junio, I've attached a fix-up patch below...
ATB, Ramsay Jones
--- >8 --- From: Ramsay Jones <ramsay@ramsay1.demon.co.uk> Date: Mon, 10 Jan 2011 23:21:26 +0000 Subject: [PATCH] t9157-*.sh: Make the svn version check more precise
These tests require an svn version 1.5 or newer to run correctly. In particular, all 1.4.x versions and earlier are too old, so fix up the case label regex to cover this range exactly.
[Fix provided by Anders Kaseorg <andersk@MIT.EDU>]
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> --- t/t9157-git-svn-fetch-merge.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t9157-git-svn-fetch-merge.sh b/t/t9157-git-svn-fetch-merge.sh index accf61e..991d2aa 100755 --- a/t/t9157-git-svn-fetch-merge.sh +++ b/t/t9157-git-svn-fetch-merge.sh @@ -8,7 +8,7 @@ test_description='git svn merge detection' svn_ver="$(svn --version --quiet)" case $svn_ver in -[0-1].[0-4].[0-6]) +0.* | 1.[0-4].*) skip_all="skipping git-svn test - SVN too old ($svn_ver)" test_done ;;
-- 1.7.3