Re: [RFC/PATCH] t9157-*.sh: Add an svn version check

From: Eric Wong <normalperson@yhbt.net>
Date: Jan 7, 2011, 17:31 UTC
Message-ID: <20110107173114.GA31376@dcvr.yhbt.net>
In-Reply-To: <4D260A03.90903@ramsay1.demon.co.uk>

Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:

Show 12 quoted lines

> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> ---
> 
> This test fails for me, because my svn version(s) are too old (1.4.3
> and 1.4.6), and so I've got into the habit of running the tests with
> NO_SVN_TESTS=1. (which is a bit of a shame in terms of test coverage,
> but it is *much* quicker!)
> 
> I don't know the details, but it seems that the 'svn merge' of this
> vintage does not support the operations required by this test.
> Unfortunately, I don't know what the minimum required version of svn
> is, so I'm hoping that someone can take this patch and fix it up
> properly ...

I'm fine taking this patch as-is or even making it just apply to all 1.4.x versions. 1.5+ has been out for ages now and eventually the rest of the world will just upgrade.

Consider this
Acked-by: Eric Wong <normalperson@yhbt.net>

-- 
Eric Wong