Re: [PATCH] t9010: svnadmin can fail even if available
- From
A Large Angry SCM <gitzilla@gmail.com>
- Date
- Jan 6, 2011, 18:32 UTC
- Message-ID
- <4D260AB9.2060406@gmail.com>
- In-Reply-To
- <20110106180051.GC11346@burratino>
On 01/06/2011 01:00 PM, Jonathan Nieder wrote:
Show 28 quoted lines
> If svn is built against one version of SQLite and run against > another, svnadmin (needlessly) errors out during t9010: > > <<< Started new transaction, based on original revision 1 > * adding path : branches ... done. > * adding path : trunk ... done. > svnadmin: Couldn't perform atomic initialization > svnadmin: Couldn't perform atomic initialization > svnadmin: SQLite compiled for 3.7.4, but running with 3.7.3 > > Work around this by putting the svn invocations into a single test > that builds a repo to compare the test-svn-fe result against. This > test would always pass but only set the new SVNREPO test prereq if svn > succeeds; and the test using that repo gets an SVNREPO prerequisite so > it only runs with working svn installations. > > This seems like the right thing to, anyway: the test script is meant > to test the version of git just built, not the installed svn. > > As a side effect, earlier tests will run now even if svn is not > installed. Remove the svn_cmd () helper to decrease the temptation to > run svn from those tests. > > Works-around: http://bugs.debian.org/608925 > Reported-by: A Large Angry SCM<gitzilla@gmail.com> > Signed-off-by: Jonathan Nieder<jrnieder@gmail.com> > --- > Thanks. Does this patch work for you?
$ sh t9010-svn-fe.sh ok 1 - empty dump ok 2 - v3 dumps not supported ok 3 - set up svn repo ok 4 # skip t9135/svn.dump (missing SVNREPO) # passed all 4 test(s) 1..4
Rerunning the full test suite now ...