Re: [PATCH] t9010: svnadmin can fail even if available

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 7, 2011, 01:31 UTC
Message-ID: <20110107013159.GA23280@burratino>
In-Reply-To: <7vpqs98qti.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

> Jonathan Nieder <jrnieder@gmail.com> writes:

Show 5 quoted lines

>>> Also isn't the breakage not just this test, but also in all the tests that
>>> try to run "svnadmin load"?  Shouldn't we somehow hoist this logic out of
>>> t9010 and put it in t/lib-vcs-svn.sh or somewhere?
>
> Am I mistaken and t9010 is the only one that needs the fix in your patch?

Everything except t9010 is testing git-svn. My argument before was that this libsvn_subr breakage is going to leave git-svn broken anyway, so why bother guarding against it in tests?

That precise argument is broken in at least three ways:

 - the libsvn_subr breakage would only breaks "git svn dcommit" (and
   "git svn set-tree") and only when the remote svn repo is actually a
   local svn repo using the FSFS backend.

 - maybe the next time "svnadmin load" breaks it will not break
   git svn

 - this particular breakage seems especially unworthy of workarounds
   because it is so easy to fix on the svn side.

So why do I like the patch to t9010? Two reasons: first, it means t9010 could run on systems without svn installed at all, and second, it means that there is one less test to worry about if svn fails in some other way in the future.

To do the same for t91* would be impossible. If svn is broken or not installed, svn-fe will run fine, but "git svn" will not. On the other hand, if svnadmin were broken but svn still worked, "git svn" would be fine but that would be quite strange and I do not think it is worth spending time to prepare for.