git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 10/14] fast-export.c: Initialise variable to suppress msvc warning

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Dec 4, 2010, 19:09 UTC
Message-ID
<4CFA91DB.6030304@ramsay1.demon.co.uk>

The msvc compiler thinks that a variable could be used while uninitialised and issues the following warning:

    ...\git\builtin\fast-export.c(466) : warning C4700: uninitialized \
        local variable 'commit' used

In order to suppress the warning, we simply initialise the commit pointer variable to NULL.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 builtin/fast-export.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin/fast-export.c b/builtin/fast-export.c
index c8fd46b..38091fb 100644
--- a/builtin/fast-export.c
+++ b/builtin/fast-export.c
@@ -463,7 +463,7 @@ static void get_tags_and_duplicates(struct object_array *pending,
 	for (i = 0; i < pending->nr; i++) {
 		struct object_array_entry *e = pending->objects + i;
 		unsigned char sha1[20];
-		struct commit *commit = commit;
+		struct commit *commit = NULL;
 		char *full_name;
 
 		if (dwim_ref(e->name, strlen(e->name), sha1, &full_name) != 1)
-- 
1.7.3
Message 1 of 1 in “fast-export.c: Initialise variable to suppress msvc warning”
  1. 10/14 fast-export.c: Initialise variable to suppress msvc warningRamsay Jones, Dec 4, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.