threads / patch / 25965

patch, 14 partsfast-export.c: Initialise variable to suppress msvc warning

Subject: [PATCH 10/14] fast-export.c: Initialise variable to suppress msvc warning

## tl;dr

One message between Dec 4, 2010 and Dec 4, 2010. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Ramsay Jones· Dec 4, 2010, 19:09 UTC · lore

The msvc compiler thinks that a variable could be used while uninitialised and issues the following warning:

    ...\git\builtin\fast-export.c(466) : warning C4700: uninitialized \
        local variable 'commit' used

In order to suppress the warning, we simply initialise the commit pointer variable to NULL.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 builtin/fast-export.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to builtin/fast-export.c +1 −1
diff --git a/builtin/fast-export.c b/builtin/fast-export.c
index c8fd46b..38091fb 100644
--- a/builtin/fast-export.c
+++ b/builtin/fast-export.c
@@ -463,7 +463,7 @@ static void get_tags_and_duplicates(struct object_array *pending,
 	for (i = 0; i < pending->nr; i++) {
 		struct object_array_entry *e = pending->objects + i;
 		unsigned char sha1[20];
-		struct commit *commit = commit;
+		struct commit *commit = NULL;
 		char *full_name;
 
 		if (dwim_ref(e->name, strlen(e->name), sha1, &full_name) != 1)
-- 
1.7.3

← back to recent threads