git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC] Add way to make Git credentials accessible from clean/smudge filter

From
Lars Schneider <larsxschneider@gmail.com>
Date
Nov 10, 2016, 11:52 UTC
Message-ID
<4C8C5650-7221-4F62-A9CC-81AE01EF6DC7@gmail.com>
Hi,

we just implemented the first "real-world" user of the new clean/smudge "filter protocol" interface (see "convert: add filter.<driver>.process option" edcc858 for details) and the results are fantastic. Filtering 12,000 files in my artificial test repo is more than 60x faster (depending on the platform). On Windows that means the clean/smudge operations runs in 57 seconds instead of 55 minutes [1]!

I have a number of ideas to improve the protocol even further and I am seeking early feedback on the following - possibly most controversial - idea:

Some filters might want to perform additional network interactions and these filters would like to use the Git credentials to perform these actions. If such a filter is configured with "offerCredentials = true" then the filter could request the current Git credentials via the "filter-protocol".

A configuration could look like this:
------------------------
[filter "myfilter"]
    process = my-filter-process
    required = true
    offerCredentials = true
------------------------
The default would, of course, be "offerCredentials = false".

I haven't looked at an implemenation approach at all. I wonder if this could be OK from a conceptional point of view or if there are obvious security problems that I am missing.

Thanks, Lars

[1] https://github.com/github/git-lfs/pull/1617#issuecomment-259411850
Next: Matthieu Moy
Message 1 of 9 in “[RFC] Add way to make Git credentials accessible from clean/smudge filter”
  1. Lars SchneiderNov 10, 2016
  2. Matthieu MoyNov 10, 2016
  3. Jeff KingNov 10, 2016
  4. Lars SchneiderNov 11, 2016
  5. Jeff KingNov 11, 2016
  6. Lars SchneiderNov 11, 2016
  7. Dennis KaarsemakerNov 11, 2016
  8. Jeff KingNov 11, 2016
  9. Lars SchneiderNov 12, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.