Re: [RFC] Add way to make Git credentials accessible from clean/smudge filter

From: Jeff King <peff@peff.net>
Date: Nov 10, 2016, 16:08 UTC
Message-ID: <20161110160809.2gvf67rlnvounulf@sigill.intra.peff.net>
In-Reply-To: <vpqoa1n1qom.fsf@anie.imag.fr>

On Thu, Nov 10, 2016 at 01:10:17PM +0100, Matthieu Moy wrote:

Show 11 quoted lines

> Lars Schneider <larsxschneider@gmail.com> writes:
> 
> > I haven't looked at an implemenation approach at all. I wonder if this could
> > be OK from a conceptional point of view or if there are obvious security 
> > problems that I am missing.
> 
> Did you consider just running "git credential" from the filter? It may
> not be the perfect solution, but it should work. I already used it to
> get credential from a remote-helper (git-remote-mediawiki). When
> prompting credentials interactively, it grabs the terminal directly, so
> it work even if stdin/stdout are used for the protocol.

Yeah, that is the solution I was going to suggest. The credentials are totally orthogonal to the filters, and I would rather not shove them into the protocol. It's an extra process, but with the new multi-use smudge filter, it's one per git invocation, not one per file.

-Peff