git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Why isn't builtin.h used by all builtin/*.c files?

From
Stephen Boyd <bebarino@gmail.com>
Date
Sep 1, 2010, 14:56 UTC
Message-ID
<4C7E69A5.4070008@gmail.com>
In-Reply-To
<AANLkTinHtvHt0q=dK9KHtCX6JzymB5dx1NuaAZN_uu2R@mail.gmail.com>
 On 09/01/2010 07:17 AM, Ævar Arnfjörð Bjarmason wrote:
> I'm working on gettextizing the 'mainporcelain common' commands now,
> and I ran into this:
>
[snip]
>
> Anyway, I'll convert these to builtin.h where appropriate as part of
> the series unless someone can find a good reason not to.

Sparse warns about this too. "Prototype not found, should it be static?" for a few cmd_*'s. So sounds good to me.

Previous: Ævar Arnfjörð BjarmasonNext: Junio C Hamano
Message 2 of 5 in “Why isn't builtin.h used by all builtin/*.c files?”
  1. Ævar Arnfjörð BjarmasonSep 1, 2010
  2. Stephen BoydSep 1, 2010
  3. Junio C HamanoSep 1, 2010
  4. builtin: use builtin.h for all builtin/ commandsÆvar Arnfjörð Bjarmason, Sep 1, 2010
  5. Junio C HamanoSep 1, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.