From: Stephen Boyd Date: Wed, 01 Sep 2010 14:56:37 GMT Subject: Re: Why isn't builtin.h used by all builtin/*.c files? Message-ID: <4C7E69A5.4070008@gmail.com> In-Reply-To: On 09/01/2010 07:17 AM, Ævar Arnfjörð Bjarmason wrote: > I'm working on gettextizing the 'mainporcelain common' commands now, > and I ran into this: > [snip] > > Anyway, I'll convert these to builtin.h where appropriate as part of > the series unless someone can find a good reason not to. Sparse warns about this too. "Prototype not found, should it be static?" for a few cmd_*'s. So sounds good to me.