Re: [RFC PATCH] rerere: fix overeager gc

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Jun 30, 2010, 06:12 UTC
Message-ID: <4C2AE04E.9090901@viscovery.net>
In-Reply-To: <7vy6dx90uk.fsf@alter.siamese.dyndns.org>

Am 6/29/2010 19:59, schrieb Junio C Hamano:

> One possibility is to look at the timestamp of the directory itself
> instead.  Then we can safely gc otherwise-unused "thisimage" file when
> rerere is not in use.  I wonder if directory m_time timestamps are usable
> for this purpose on non-POSIX platforms?

I don't think that will work at all: We only use fopen() to write thisimage, which only truncates the file, but doesn't modify mtime of the directory. Nor do we create any other (temporary) directory entries that would modify the mtime.

Would it be possible to update the timestamp of preimage every time it is used (e.g., in rerere.c:merge()), and check for that?

-- Hannes