git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2 v2] git-gui - provide commit base to the hooks/pre-commit script

From
Mark Levedahl <mlevedahl@gmail.com>
Date
Jun 22, 2010, 01:07 UTC
Message-ID
<4C200CED.7090402@gmail.com>
In-Reply-To
<20100621050012.GA13043@coredump.intra.peff.net>
On 06/21/2010 01:00 AM, Jeff King wrote:
Show 14 quoted lines
> On Sun, Jun 20, 2010 at 09:54:39PM -0700, Junio C Hamano wrote:
>
>    
>> I generally take absense of responses as absense of interest and/or
>> support, not absense of objection.
>>
>> For this particular patch, I am mostly indifferent (i.e. no objection, but
>> no strong support neither).
>>      
> Ditto. I don't personally have a use, but all of my concerns were
> answered.
>
> -Peff
>    
Well, I have a use else I wouldn't have written this :^).

Absent this patch, the default commit hook is always computing a diff against HEAD and that is wrong when amending a commit. Folks may not care, but that is an error so this patch fixes an existing bug. I'll leave it at that.

Mark
Previous: Jeff King
Message 6 of 6 in “commit.c - provide base commit to the hooks/pre-commit script”
  1. 1/2 commit.c - provide base commit to the hooks/pre-commit scriptMark Levedahl, Jun 8, 2010
  2. 2/2 git-gui - provide commit base to the hooks/pre-commit scriptMark Levedahl, Jun 8, 2010
  3. Mark LevedahlJun 19, 2010
  4. Junio C HamanoJun 21, 2010
  5. Jeff KingJun 21, 2010
  6. Mark LevedahlJun 22, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.