From: Mark Levedahl <mlevedahl@gmail.com>
Date: Tue, 22 Jun 2010 01:07:57 GMT
Subject: Re: [PATCH 2/2 v2] git-gui - provide commit base to the hooks/pre-commit script
Message-ID: <4C200CED.7090402@gmail.com>
In-Reply-To: <20100621050012.GA13043@coredump.intra.peff.net>

On 06/21/2010 01:00 AM, Jeff King wrote:
> On Sun, Jun 20, 2010 at 09:54:39PM -0700, Junio C Hamano wrote:
>
>    
>> I generally take absense of responses as absense of interest and/or
>> support, not absense of objection.
>>
>> For this particular patch, I am mostly indifferent (i.e. no objection, but
>> no strong support neither).
>>      
> Ditto. I don't personally have a use, but all of my concerns were
> answered.
>
> -Peff
>    
Well, I have a use else I wouldn't have written this :^).

Absent this patch, the default commit hook is always computing a diff 
against HEAD and that is wrong when amending a commit. Folks may not 
care, but that is an error so this patch fixes an existing bug. I'll 
leave it at that.

Mark