git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] grep -O: allow optional argument specifying the pager (or editor)

From
Paolo Bonzini <bonzini@gnu.org>
Date
Jun 12, 2010, 17:16 UTC
Message-ID
<4C13C0E1.3070707@gnu.org>
In-Reply-To
<20100612163946.GD5657@burratino>
On 06/12/2010 06:39 PM, Jonathan Nieder wrote:
Show 12 quoted lines
> From: Johannes Schindelin<johannes.schindelin@gmx.de>
>
> Suppose you want to edit all files that contain a specific search term.
> Of course, you can do something totally trivial such as
>
> 	git grep -z -e<term>  | xargs -0r vi +/<term>
>
> but maybe you are happy that the same will be achieved by
>
> 	git grep -Ovi<term>
>
> now.

Ah, I had missed that the argument was optional. I think that optional arguments are slightly frowned upon for POSIX utilities, because they're a bit different. In fact, I think the only one is -i in sed (and BSD sed instead makes it mandatory...). Personally I have no problem with making -O in GNU grep optional too, I'll see what the other maintainers say.

Acked-by: Paolo Bonzini <bonzini@gnu.org>
Paolo
Previous: Jonathan NiederNext: Junio C Hamano
Message 13 of 20 in “Teach 'git grep' about --open-files-in-pager=[<pager>]”
  1. 0/2 Teach 'git grep' about --open-files-in-pager=[<pager>]Jonathan Nieder, Jun 5, 2010
  2. 1/2 grep: Add the option '--open-files-in-pager'Jonathan Nieder, Jun 5, 2010
  3. Jonathan NiederJun 5, 2010
  4. 2/2 grep -O: allow optional argument specifying the pager (or editor)Jonathan Nieder, Jun 5, 2010
  5. Johannes SchindelinJun 5, 2010
  6. Jonathan NiederJun 12, 2010
  7. Johannes SchindelinJun 12, 2010
  8. 0/4 Teach 'git grep' about --open-files-in-pager=[<pager>]Jonathan Nieder, Jun 12, 2010
  9. 1/4 grep: refactor grep_objects loop into its own functionJonathan Nieder, Jun 12, 2010
  10. 2/4 Unify code paths of threaded grepsJonathan Nieder, Jun 12, 2010
  11. 3/4 grep: Add the option '--open-files-in-pager'Jonathan Nieder, Jun 12, 2010
  12. 4/4 grep -O: allow optional argument specifying the pager (or editor)Jonathan Nieder, Jun 12, 2010
  13. Paolo BonziniJun 12, 2010
  14. Junio C HamanoJun 13, 2010
  15. Paolo BonziniJun 13, 2010
  16. Jonathan NiederJun 14, 2010
  17. Johannes SchindelinJun 12, 2010
  18. Jonathan NiederJun 12, 2010
  19. Paolo BonziniJun 12, 2010
  20. Jonathan NiederJun 12, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.