[PATCH v3 0/4] Teach 'git grep' about --open-files-in-pager=[<pager>]

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jun 12, 2010, 16:29 UTC
Message-ID: <20100612162945.GB1406@burratino>
In-Reply-To: <alpine.DEB.1.00.1006121139290.2689@bonsai2>

Johannes Schindelin wrote:

> Nope, the patch is still there, even after a rebase.

Ah, I see. Looks like a good patch (d00d655, Unify code paths of threaded greps, 2010-02-07) though in principle a separate topic, since grep -O already sets use_threads = 0. I think it is good to base grep-O on it because it allows cleaner code.

Here’s a rebased version.

Johannes Schindelin (3):
  Unify code paths of threaded greps
  grep: Add the option '--open-files-in-pager'
  grep -O: allow optional argument specifying the pager (or editor)

Jonathan Nieder (1):
  grep: refactor grep_objects loop into its own function

 Documentation/git-grep.txt         |    8 ++
 builtin/grep.c                     |  121 ++++++++++++++++++++++------
 git.c                              |    2 +-
 t/lib-pager.sh                     |   15 ++++
 t/t7006-pager.sh                   |   16 +---
 t/{t7002-grep.sh => t7810-grep.sh} |    0
 t/t7811-grep-open.sh               |  157 ++++++++++++++++++++++++++++++++++++
 7 files changed, 280 insertions(+), 39 deletions(-)
 create mode 100644 t/lib-pager.sh
 rename t/{t7002-grep.sh => t7810-grep.sh} (100%)
 create mode 100755 t/t7811-grep-open.sh