git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/7] grep: add regmatch(), a wrapper for REG_STARTEND handling

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
May 13, 2010, 20:40 UTC
Message-ID
<4BEC63C0.7080207@lsrfire.ath.cx>
In-Reply-To
<4BEC6211.2000309@lsrfire.ath.cx>
Refactor REG_STARTEND handling into a new helper, regmatch().
Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
---
 grep.c |   22 +++++++++++++---------
 1 files changed, 13 insertions(+), 9 deletions(-)
diff --git a/grep.c b/grep.c
index 31c0e38..5be72cf 100644
--- a/grep.c
+++ b/grep.c
@@ -359,6 +359,17 @@ static int fixmatch(const char *pattern, char *line, char *eol,
 	}
 }
 
+static int regmatch(const regex_t *preg, char *line, char *eol,
+		    regmatch_t *match, int eflags)
+{
+#ifdef REG_STARTEND
+	match->rm_so = 0;
+	match->rm_eo = eol - line;
+	eflags |= REG_STARTEND;
+#endif
+	return regexec(preg, line, 1, match, eflags);
+}
+
 static int strip_timestamp(char *bol, char **eol_p)
 {
 	char *eol = *eol_p;
@@ -738,15 +749,8 @@ static int look_ahead(struct grep_opt *opt,
 		if (p->fixed) {
 			hit = !fixmatch(p->pattern, bol, bol + *left_p,
 					p->ignore_case, &m);
-		} else {
-#ifdef REG_STARTEND
-			m.rm_so = 0;
-			m.rm_eo = *left_p;
-			hit = !regexec(&p->regexp, bol, 1, &m, REG_STARTEND);
-#else
-			hit = !regexec(&p->regexp, bol, 1, &m, 0);
-#endif
-		}
+		} else
+			hit = !regmatch(&p->regexp, bol, bol + *left_p, &m, 0);
 		if (!hit || m.rm_so < 0 || m.rm_eo < 0)
 			continue;
 		if (earliest < 0 || m.rm_so < earliest)
-- 
1.7.1
Previous: René ScharfeNext: René Scharfe
Message 9 of 10 in “grep: better support for binary files”
  1. 0/7 grep: better support for binary filesRené Scharfe, May 13, 2010
  2. 1/7 grep: add test script for binary file handlingRené Scharfe, May 13, 2010
  3. 2/7 grep: refactor handling of binary mode optionsRené Scharfe, May 13, 2010
  4. 3/7 grep: --count over binaryRené Scharfe, May 13, 2010
  5. Dmitry PotapovMay 14, 2010
  6. René ScharfeMay 16, 2010
  7. 4/7 grep: use memmem() for fixed string searchRené Scharfe, May 13, 2010
  8. 5/7 grep: continue case insensitive fixed string search after NUL charsRené Scharfe, May 13, 2010
  9. 6/7 grep: add regmatch(), a wrapper for REG_STARTEND handlingRené Scharfe, May 13, 2010
  10. 7/7 grep: use regmatch() for line matchingRené Scharfe, May 13, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.