git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/7] grep: continue case insensitive fixed string search after NUL chars

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
May 13, 2010, 20:39 UTC
Message-ID
<4BEC6385.8000106@lsrfire.ath.cx>
In-Reply-To
<4BEC6211.2000309@lsrfire.ath.cx>

Functions for C strings, like strcasestr(), can't see beyond NUL characters. Check if there is such an obstacle on the line and try again behind it.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
---
 grep.c                 |   12 +++++++++---
 t/t7008-grep-binary.sh |    4 ++++
 2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/grep.c b/grep.c
index 4633b63..20a02a2 100644
--- a/grep.c
+++ b/grep.c
@@ -334,9 +334,15 @@ static int fixmatch(const char *pattern, char *line, char *eol,
 {
 	char *hit;
 
-	if (ignore_case)
-		hit = strcasestr(line, pattern);
-	else
+	if (ignore_case) {
+		char *s = line;
+		do {
+			hit = strcasestr(s, pattern);
+			if (hit)
+				break;
+			s += strlen(s) + 1;
+		} while (s < eol);
+	} else
 		hit = memmem(line, eol - line, pattern, strlen(pattern));
 
 	if (!hit) {
diff --git a/t/t7008-grep-binary.sh b/t/t7008-grep-binary.sh
index ad97720..1143903 100755
--- a/t/t7008-grep-binary.sh
+++ b/t/t7008-grep-binary.sh
@@ -37,4 +37,8 @@ test_expect_success 'git grep -F ile a' '
 	git grep -F ile a
 '
 
+test_expect_success 'git grep -Fi iLE a' '
+	git grep -Fi iLE a
+'
+
 test_done
-- 
1.7.1
Previous: René ScharfeNext: René Scharfe
Message 8 of 10 in “grep: better support for binary files”
  1. 0/7 grep: better support for binary filesRené Scharfe, May 13, 2010
  2. 1/7 grep: add test script for binary file handlingRené Scharfe, May 13, 2010
  3. 2/7 grep: refactor handling of binary mode optionsRené Scharfe, May 13, 2010
  4. 3/7 grep: --count over binaryRené Scharfe, May 13, 2010
  5. Dmitry PotapovMay 14, 2010
  6. René ScharfeMay 16, 2010
  7. 4/7 grep: use memmem() for fixed string searchRené Scharfe, May 13, 2010
  8. 5/7 grep: continue case insensitive fixed string search after NUL charsRené Scharfe, May 13, 2010
  9. 6/7 grep: add regmatch(), a wrapper for REG_STARTEND handlingRené Scharfe, May 13, 2010
  10. 7/7 grep: use regmatch() for line matchingRené Scharfe, May 13, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.