git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: 1.7.2 cycle will open soon

From
Johannes Sixt <j.sixt@viscovery.net>
Date
May 6, 2010, 07:06 UTC
Message-ID
<4BE26A83.4010708@viscovery.net>
In-Reply-To
<20100506064428.GA29360@progeny.tock>
Am 5/6/2010 8:44, schrieb Jonathan Nieder:
>  test_when_finished () {
> 	test_cleanup="$* && $test_cleanup"
>  }
I'm wondering why you want this test_cleanup at all?

Is it so that subsequent tests can succeed even if an earlier test failed before its regular cleanup?

I don't see what this buys you. If a test case uncovers a regression, you got to fix it - who cares how many later tests fail or not? Once you are finished with your change, all tests will pass anyway (including their regular cleanups).

-- Hannes
Previous: Junio C HamanoNext: Jeff King
Message 8 of 11 in “1.7.2 cycle will open soon”
  1. Junio C HamanoMay 5, 2010
  2. Jeff KingMay 6, 2010
  3. Jonathan NiederMay 6, 2010
  4. Jeff KingMay 6, 2010
  5. test-lib: some shells do not let $? propagate into an evalJonathan Nieder, May 6, 2010
  6. Jeff KingMay 6, 2010
  7. Junio C HamanoMay 6, 2010
  8. Johannes SixtMay 6, 2010
  9. Jeff KingMay 6, 2010
  10. Jonathan NiederMay 6, 2010
  11. Johannes SixtMay 6, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.