git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: 1.7.2 cycle will open soon

From
Johannes Sixt <j.sixt@viscovery.net>
Date
May 6, 2010, 06:57 UTC
Message-ID
<4BE2684F.1080004@viscovery.net>
In-Reply-To
<20100506055236.GA16151@coredump.intra.peff.net>
Am 5/6/2010 7:52, schrieb Jeff King:
Show 15 quoted lines
> Why not just:
> 
>   test_run_ () {
>     test_cleanup=
>     eval >&3 2>&4 "$1"
>     eval_ret=$?
>     eval >&3 2>&4 "$test_cleanup"
>     return 0
>   }
> 
>   test_when_finished () {
>     test_cleanup="$*; $test_cleanup"
>   }
> 
> Am I missing something?
I ask myself the same question.

For my taste, this change went production far too fast. Did I miss any discussion on it? (I didn't speak up when it passed by on the ML because I was on a short trip at that time.)

-- Hannes
Previous: Jonathan Nieder
Message 11 of 11 in “1.7.2 cycle will open soon”
  1. Junio C HamanoMay 5, 2010
  2. Jeff KingMay 6, 2010
  3. Jonathan NiederMay 6, 2010
  4. Jeff KingMay 6, 2010
  5. test-lib: some shells do not let $? propagate into an evalJonathan Nieder, May 6, 2010
  6. Jeff KingMay 6, 2010
  7. Junio C HamanoMay 6, 2010
  8. Johannes SixtMay 6, 2010
  9. Jeff KingMay 6, 2010
  10. Jonathan NiederMay 6, 2010
  11. Johannes SixtMay 6, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.