Re: [PATCHv4 6/6] is_submodule_modified(): clear environment properly

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Feb 24, 2010, 09:18 UTC
Message-ID: <4B84EEF2.2030502@viscovery.net>
In-Reply-To: <cb7bb73a1002240055v58953dcfh3be7c4589523b14b@mail.gmail.com>

Giuseppe Bilotta schrieb:

Show 7 quoted lines

> On Wed, Feb 24, 2010 at 9:06 AM, Johannes Sixt <j.sixt@viscovery.net> wrote:
>> Giuseppe Bilotta schrieb:
>>> +     const char *env[local_repo_env_size+2];
>> Variable sized arrays are prohibited.
> 
> Ah, sorry. Is alloca() allowed? I don't see it being used anywhere
> else in the code, and malloc would be a little too much for this case.

in cache.h:

#define LOCAL_REPO_ENV_CAPACITY 20 const char *const l_r_e[];

in environtment.c:

const char *const l_r_e[LOCAL_REPO_ENV_CAPACITY] = { ..., NULL };

and the compiler will croak if the constant becomes too small. (Oh, I know, you must use the 'inconsistent mode' that I nit-picked if you use this approach.)

-- Hannes