git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv4 2/6] connect: use static list of repo-local env vars

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Feb 24, 2010, 07:23 UTC
Message-ID
<1266996196-25978-3-git-send-email-giuseppe.bilotta@gmail.com>
In-Reply-To
<1266996196-25978-1-git-send-email-giuseppe.bilotta@gmail.com>

This adds the missing GIT_CONFIG to the list of env vars that should be cleared.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
---
 connect.c |   13 +------------
 1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/connect.c b/connect.c
index 9f39038..94b3707 100644
--- a/connect.c
+++ b/connect.c
@@ -582,18 +582,7 @@ struct child_process *git_connect(int fd[2], const char *url_orig,
 		*arg++ = host;
 	}
 	else {
-		/* remove these from the environment */
-		const char *env[] = {
-			ALTERNATE_DB_ENVIRONMENT,
-			DB_ENVIRONMENT,
-			GIT_DIR_ENVIRONMENT,
-			GIT_WORK_TREE_ENVIRONMENT,
-			GRAFT_ENVIRONMENT,
-			INDEX_ENVIRONMENT,
-			NO_REPLACE_OBJECTS_ENVIRONMENT,
-			NULL
-		};
-		conn->env = env;
+		conn->env = local_repo_env;
 		conn->use_shell = 1;
 	}
 	*arg++ = cmd.buf;
-- 
1.7.0.212.g4e217.dirty
Previous: Giuseppe BilottaNext: Giuseppe Bilotta
Message 7 of 15 in “[PATCHv4 0/6] repo-local env vars handling”
  1. Giuseppe BilottaFeb 24, 2010
  2. 1/6 environment: static list of repo-local env varsGiuseppe Bilotta, Feb 24, 2010
  3. Junio C HamanoFeb 24, 2010
  4. Giuseppe BilottaFeb 24, 2010
  5. Junio C HamanoFeb 24, 2010
  6. Giuseppe BilottaFeb 24, 2010
  7. 2/6 connect: use static list of repo-local env varsGiuseppe Bilotta, Feb 24, 2010
  8. 3/6 rev-parse: --local-env-vars optionGiuseppe Bilotta, Feb 24, 2010
  9. 4/6 shell setup: clear_local_git_env() functionGiuseppe Bilotta, Feb 24, 2010
  10. 5/6 submodules: ensure clean environment when operating in a submoduleGiuseppe Bilotta, Feb 24, 2010
  11. 6/6 is_submodule_modified(): clear environment properlyGiuseppe Bilotta, Feb 24, 2010
  12. Johannes SixtFeb 24, 2010
  13. Giuseppe BilottaFeb 24, 2010
  14. Johannes SixtFeb 24, 2010
  15. Giuseppe BilottaFeb 24, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.